fix(fetcher/exploitdb): fill in nil even if Document etc. is not found (

#158)
vulsio · Sep 6, 2023 · 9898d2c · 9898d2c
1 parent 073fce1
commit 9898d2c
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 14 deletions.
diff --git a/fetcher/exploitdb.go b/fetcher/exploitdb.go
@@ -385,17 +385,19 @@ func joinExploits(toCVEs map[string][]string, toDocument map[string]models.Docum
 		if len(cves) > 0 {
 			for _, cve := range cves {
 				toExploits[id] = append(toExploits[id], models.Exploit{
-					ExploitType:     models.OffensiveSecurityType,
-					ExploitUniqueID: id,
-					URL:             fmt.Sprintf("https://www.exploit-db.com/exploits/%s", id),
-					CveID:           cve,
+					ExploitType:       models.OffensiveSecurityType,
+					ExploitUniqueID:   id,
+					URL:               fmt.Sprintf("https://www.exploit-db.com/exploits/%s", id),
+					CveID:             cve,
+					OffensiveSecurity: &models.OffensiveSecurity{},
 				})
 			}
 		} else {
 			toExploits[id] = append(toExploits[id], models.Exploit{
-				ExploitType:     models.OffensiveSecurityType,
-				ExploitUniqueID: id,
-				URL:             fmt.Sprintf("https://www.exploit-db.com/exploits/%s", id),
+				ExploitType:       models.OffensiveSecurityType,
+				ExploitUniqueID:   id,
+				URL:               fmt.Sprintf("https://www.exploit-db.com/exploits/%s", id),
+				OffensiveSecurity: &models.OffensiveSecurity{},
 			})
 		}
 	}
@@ -548,9 +550,6 @@ func joinExploits(toCVEs map[string][]string, toDocument map[string]models.Docum
 			continue
 		}
 		for i := range es {
-			if es[i].OffensiveSecurity == nil {
-				es[i].OffensiveSecurity = &models.OffensiveSecurity{}
-			}
 			es[i].OffensiveSecurity.GHDB = &models.GHDB{
 				Link:               ghdb.Link,
 				Category:           ghdb.Category,

diff --git a/fetcher/exploitdb_test.go b/fetcher/exploitdb_test.go
@@ -81,10 +81,11 @@ func Test_joinExploits(t *testing.T) {
 			},
 			want: []models.Exploit{
 				{
-					ExploitType:     models.OffensiveSecurityType,
-					ExploitUniqueID: "0",
-					URL:             "https://www.exploit-db.com/exploits/0",
-					CveID:           "CVE-0000-0000",
+					ExploitType:       models.OffensiveSecurityType,
+					ExploitUniqueID:   "0",
+					URL:               "https://www.exploit-db.com/exploits/0",
+					CveID:             "CVE-0000-0000",
+					OffensiveSecurity: &models.OffensiveSecurity{},
 				},
 				{
 					ExploitType:     models.OffensiveSecurityType,

diff --git a/models/exploit.go b/models/exploit.go
@@ -51,6 +51,7 @@ type OffensiveSecurity struct {
 	GHDB      *GHDB      `json:"ghdb,omitempty"`
 }
 
+// Base :
 type Base struct {
 	FileURL        string     `gorm:"type:varchar(255)" json:"file_url"`
 	Description    string     `gorm:"type:text" json:"description"`