Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fix GetMicrosoftMulti nil pointer dereference and add GetDebianMulti, GetUbuntuMulti #81

Merged
merged 6 commits into from
Sep 19, 2021

Conversation

MaineK00n
Copy link
Collaborator

What did you implement:

If CVE==nil in GetMicrosoftMulti in RDB, do not register it.
refs. #79

Also, GetDebianMulti and GetUbuntuMulti are implemented.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

$ gost server --dbtype sqlite3 --dbpath ./gost.sqlite3
$ curl -H "Content-type: application/json" -X POST -d '{"cveIDs": []}' http://127.0.0.1:1325/microsoft/multi-cves | jq . // empty CVEIDs
$ curl -H "Content-type: application/json" -X POST -d '{"cveIDs": ["CVE-0000-0000", "CVE-2021-38642"]}' http://127.0.0.1:1325/microsoft/multi-cves | jq . // contains invalid CVEID

Checklist:

You don't have to satisfy all of the following.

  • Write tests
  • Write documentation
  • Check that there aren't other open pull requests for the same issue/feature
  • Format your source code by make fmt
  • Pass the test by make test
  • Provide verification config / commands
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES

Reference

@MaineK00n MaineK00n self-assigned this Sep 18, 2021
@kotakanbe kotakanbe merged commit 2a7957b into master Sep 19, 2021
@kotakanbe kotakanbe deleted the MaineK00n/fix-ms-nil-pointer branch September 20, 2021 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants