Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(redis): pipe cannot take err except for pipe.Exec #92

Merged
merged 1 commit into from
Jan 6, 2022
Merged

fix(redis): pipe cannot take err except for pipe.Exec #92

merged 1 commit into from
Jan 6, 2022

Conversation

MaineK00n
Copy link
Collaborator

@MaineK00n MaineK00n commented Dec 8, 2021 •
edited
Loading

What did you implement:

Since pipe can't get err except for pipe.Exec, I modified the code.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Checklist:

You don't have to satisfy all of the following.

  • Write tests
  • Write documentation
  • Check that there aren't other open pull requests for the same issue/feature
  • Format your source code by make fmt
  • Pass the test by make test
  • Provide verification config / commands
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES

Reference

@MaineK00n MaineK00n self-assigned this Dec 8, 2021
@kotakanbe kotakanbe merged commit d728266 into master Jan 6, 2022
@kotakanbe kotakanbe deleted the MaineK00n/fix-pipe branch January 6, 2022 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kotakanbe kotakanbe kotakanbe approved these changes

Assignees

@MaineK00n MaineK00n

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MaineK00n @kotakanbe