Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(fetch-ubuntu): False Positive for mysql-5.7 #120 #121

Merged
merged 3 commits into from
Jan 17, 2021
Merged

fix(fetch-ubuntu): False Positive for mysql-5.7 #120 #121

merged 3 commits into from
Jan 17, 2021

Conversation

kotakanbe
Copy link
Collaborator

@kotakanbe kotakanbe commented Jan 17, 2021 •
edited
Loading

What did you implement:

Fixes #120

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

make test

Checklist:

  • Write tests
  • Write documentation
  • Check that there aren't other open pull requests for the same issue/feature
  • Format your source code by make fmt
  • Pass the test by make test
  • Provide verification config / commands
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES

@kotakanbe kotakanbe merged commit b0e8dc7 into master Jan 17, 2021
@kotakanbe kotakanbe deleted the 120 branch September 20, 2021 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

False Positive for mysql-5.7
1 participant
@kotakanbe