Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(command): specify version in amazon or oracle #289

Merged
merged 2 commits into from
Apr 17, 2023

Conversation

MaineK00n
Copy link
Collaborator

@MaineK00n MaineK00n commented Mar 16, 2023

What did you implement:

When fetching oracle or amazon, it fetches versions that are not needed. oracle and amazon should receive the version to be fetched as an argument, just like other OS.

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Checklist:

You don't have to satisfy all of the following.

  • Write tests
  • Write documentation
  • Check that there aren't other open pull requests for the same issue/feature
  • Format your source code by make fmt
  • Pass the test by make test
  • Provide verification config / commands
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES

Reference

@MaineK00n MaineK00n self-assigned this Mar 16, 2023
@MaineK00n MaineK00n force-pushed the MaineK00n/amazon-mirror branch 2 times, most recently from 59fad11 to 0a0d243 Compare March 16, 2023 10:59
@MaineK00n MaineK00n marked this pull request as ready for review March 16, 2023 11:01
@MaineK00n MaineK00n merged commit d581fbd into master Apr 17, 2023
@MaineK00n MaineK00n deleted the MaineK00n/amazon-mirror branch April 17, 2023 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants