Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support read replica promotion for Managed Databases #276

Merged
merged 1 commit into from
Nov 6, 2023
Merged

Support read replica promotion for Managed Databases #276

merged 1 commit into from
Nov 6, 2023

Conversation

christhemorse
Copy link
Contributor

Description

This PR adds support for promoting Managed Database read-only replicas to their own standalone subscriptions to match the functionality in the customer portal and Vultr API.

Checklist:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you linted your code locally prior to submission?
  • Have you successfully ran tests with your changes locally?

@christhemorse christhemorse added the enhancement New feature or request label Nov 3, 2023
@christhemorse christhemorse marked this pull request as draft November 3, 2023 17:33
@christhemorse christhemorse changed the title Draft: Support read replica promotion for Managed Databases Support read replica promotion for Managed Databases Nov 3, 2023
@christhemorse christhemorse marked this pull request as ready for review November 6, 2023 14:42
optik-aper
optik-aper approved these changes Nov 6, 2023
View reviewed changes
Copy link
Member

@optik-aper optik-aper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@optik-aper optik-aper merged commit a6dd1f5 into vultr:master Nov 6, 2023
6 checks passed
@christhemorse christhemorse deleted the dbaas-promote-replicas branch November 6, 2023 16:56
@optik-aper optik-aper mentioned this pull request Nov 10, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@optik-aper optik-aper optik-aper approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@christhemorse @optik-aper