Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace golint with golangci-lint in go-checks workflow #123

Merged
merged 6 commits into from
May 23, 2023

Conversation

optik-aper
Copy link
Member

@optik-aper optik-aper commented May 23, 2023

Description

Switch the go-checks workflow to use golangci-lint

Checklist:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you linted your code locally prior to submission?
  • Have you successfully ran tests with your changes locally?

@optik-aper optik-aper added the automation Build/release workflow related label May 23, 2023
@optik-aper optik-aper self-assigned this May 23, 2023
@github-actions
Copy link

Unit Tests and Coverage

Show Output
?   	github.com/vultr/vultr-csi/cmd/csi-vultr-driver	[no test files]
=== RUN   TestCreateVolume
time="2023-05-23T13:22:45Z" level=info msg="Create Volume: called" capabilities="[mount:<> access_mode:<mode:SINGLE_NODE_WRITER > ]" test="create volume" volume-name=volume-test-name
time="2023-05-23T13:22:46Z" level=info msg="Create Volume: created volume" size=10737418240 test="create volume" volume-id=c56c7b6e-15c2-445e-9a5d-1063ab5828ec volume-name=test-bs volume-size=10
--- PASS: TestCreateVolume (1.00s)
=== RUN   TestDeleteVolume
time="2023-05-23T13:22:46Z" level=info msg="Delete volume: called" test="delete volume" volume-id=c56c7b6e-15c2-445e-9a5d-1063ab5828ec
time="2023-05-23T13:22:46Z" level=info msg="Delete Volume: deleted" test="delete volume" volume-id=c56c7b6e-15c2-445e-9a5d-1063ab5828ec
--- PASS: TestDeleteVolume (0.00s)
=== RUN   TestPublishVolume
--- PASS: TestPublishVolume (0.00s)
=== RUN   TestUnPublishVolume
time="2023-05-23T13:22:46Z" level=info msg="Controller Publish Unpublish: called" node-id=c56c7b6e-15c2-445e-9a5d-1063ab5828ec test="delete volume" volume-id=245bb2fe-b55c-44a0-9a1e-ab80e4b5f088
time="2023-05-23T13:22:46Z" level=info msg="Controller Unublish Volume: unpublished" node-id=c56c7b6e-15c2-445e-9a5d-1063ab5828ec test="delete volume" volume-id=245bb2fe-b55c-44a0-9a1e-ab80e4b5f088
--- PASS: TestUnPublishVolume (0.00s)
=== RUN   TestDriverSuite
--- PASS: TestDriverSuite (0.00s)
PASS
coverage: 19.2% of statements
ok  	github.com/vultr/vultr-csi/driver	1.006s	coverage: 19.2% of statements

Pusher: @optik-aper, Action: pull_request_target

@github-actions
Copy link

Unit Tests and Coverage

Show Output
?   	github.com/vultr/vultr-csi/cmd/csi-vultr-driver	[no test files]
=== RUN   TestCreateVolume
time="2023-05-23T13:24:15Z" level=info msg="Create Volume: called" capabilities="[mount:<> access_mode:<mode:SINGLE_NODE_WRITER > ]" test="create volume" volume-name=volume-test-name
time="2023-05-23T13:24:16Z" level=info msg="Create Volume: created volume" size=10737418240 test="create volume" volume-id=c56c7b6e-15c2-445e-9a5d-1063ab5828ec volume-name=test-bs volume-size=10
--- PASS: TestCreateVolume (1.00s)
=== RUN   TestDeleteVolume
time="2023-05-23T13:24:16Z" level=info msg="Delete volume: called" test="delete volume" volume-id=c56c7b6e-15c2-445e-9a5d-1063ab5828ec
time="2023-05-23T13:24:16Z" level=info msg="Delete Volume: deleted" test="delete volume" volume-id=c56c7b6e-15c2-445e-9a5d-1063ab5828ec
--- PASS: TestDeleteVolume (0.00s)
=== RUN   TestPublishVolume
--- PASS: TestPublishVolume (0.00s)
=== RUN   TestUnPublishVolume
time="2023-05-23T13:24:16Z" level=info msg="Controller Publish Unpublish: called" node-id=c56c7b6e-15c2-445e-9a5d-1063ab5828ec test="delete volume" volume-id=245bb2fe-b55c-44a0-9a1e-ab80e4b5f088
time="2023-05-23T13:24:16Z" level=info msg="Controller Unublish Volume: unpublished" node-id=c56c7b6e-15c2-445e-9a5d-1063ab5828ec test="delete volume" volume-id=245bb2fe-b55c-44a0-9a1e-ab80e4b5f088
--- PASS: TestUnPublishVolume (0.00s)
=== RUN   TestDriverSuite
--- PASS: TestDriverSuite (0.00s)
PASS
time="2023-05-23T13:24:16Z" level=info msg="Start listening with scheme unix, addr /tmp/csi.sock"
coverage: 21.6% of statements
ok  	github.com/vultr/vultr-csi/driver	1.007s	coverage: 21.6% of statements

Pusher: @optik-aper, Action: pull_request_target

Copy link
Contributor

@happytreees happytreees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@happytreees happytreees merged commit 734449a into vultr:master May 23, 2023
@optik-aper optik-aper mentioned this pull request Oct 5, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation Build/release workflow related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants