Revert "Revert "NEW: запросы в базу"" #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit e835576.
churnikov
approved these changes
Jul 16, 2021
| response = requests.get(url, params=operation_options).json() | ||
| return response["PropertyTable"]["Properties"] | ||
| except KeyError: | ||
| breakpoint() |
There was a problem hiding this comment.
Чего так?
да он там иногда падает, если ответ от сервера не тот, что ожидается... я подумаю, как это нормально обработать.
There was a problem hiding this comment.
Не через breakpoint. Это неправильно, инструмент для дебаг использовать в рантайме целенаправлено
There was a problem hiding this comment.
Если ты хочешь "проглотить" ошибку, то используй pass
vvrubel
commented
Jul 18, 2021
| response = requests.get(url, params=operation_options).json() | ||
| return response["PropertyTable"]["Properties"] | ||
| except KeyError: | ||
| breakpoint() |
There was a problem hiding this comment.
Чего так?
да он там иногда падает, если ответ от сервера не тот, что ожидается... я подумаю, как это нормально обработать.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Создала отдельную ветку под запросы в базу, чтобы не мешать их
This reverts commit e835576.