Endpoints #11
Merged
Endpoints #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
churnikov
reviewed
Jul 19, 2021
molecad/api.py
Outdated
| class Properties(BaseModel): | ||
| CID: int | ||
| MolecularFormula: str | ||
| MolecularWeight: Union[float, str] # почему-то в response приходит строка |
There was a problem hiding this comment.
Может ты в базу что-то не то пишешь?..
There was a problem hiding this comment.
Может ты в базу что-то не то пишешь?..
не, там от сервера строка приходит
| @@ -25,7 +25,6 @@ class Config: | |||
| env_file = ".env" | |||
| env_file_encoding = "utf-8" | |||
|
|
|||
| @property | |||
There was a problem hiding this comment.
Почему решила убрать property?
There was a problem hiding this comment.
Почему решила убрать property?
ну типа это действие, а не свойство по смыслу, если не права поправь
churnikov
approved these changes
Jul 20, 2021
molecad/api_db.py
Outdated
| from .settings import Settings, settings | ||
|
|
||
|
|
||
| # settings = Settings(_env_file="prod.env", _env_file_encoding="utf-8") |
There was a problem hiding this comment.
И обычно дописывают так: .env.prod
molecad/utils.py
Outdated
| route = "v1/compound/summary" | ||
| else: | ||
| route = "v1/compound" | ||
| return f"http://127.0.0.1:8000/{route}?{params}" |
There was a problem hiding this comment.
параметры можно так передавать requests.get(url, params=params)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ручка
/v1/compoundsготова