Detect the new chromium-based MS Edge #60
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted in #21, until now Edge has been a funky beast built into the OS itself.
Now though, it's been rebuilt on Chrome, and it's effectively just another Chromium wrapper. You can detect and launch it standalone, just like anything else. It's currently still Beta, but very usable, and planned for official release in January.
This PR adds proper support for it. I've set up a Windows 10 VM and installed a whole bunch of things, and with this PR in place
node cli.js --debug
prints:You can see Edge at the top of the detected list there.
The 'Edge Beta' folder is the current directory. I'm assuming in future that 'Edge' will be the official folder, but just on common sense, I don't have any hard evidence for that.