[RM-1003] View details of a list #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vxduc9999
force-pushed
the
1003-view-details-of-a-list
branch
2 times, most recently
from
b087c28
to
ec73f14
Compare
vxduc9999
force-pushed
the
1003-view-details-of-a-list
branch
from
a9f24cd
to
1e608d7
Compare
vxduc9999
force-pushed
the
1003-view-details-of-a-list
branch
from
0f31ae5
to
0336952
Compare
| ], | ||
| }, | ||
| { | ||
| path: "/404", |
There was a problem hiding this comment.
The PageNotFound should appear whenever the URL doesn't match any of the exact URLs in our routes.
Suggested change
| path: "/404", | |
| path: "*", |
There was a problem hiding this comment.
Sorry for the incorrect suggestion above as it may lead to an unexpected error when clicking on a newly created list. Please revert the change and refer to this guide if needed.
phuphamphong97
approved these changes
Jul 15, 2021
vxduc9999
force-pushed
the
1003-view-details-of-a-list
branch
from
a545edd
to
2f4be57
Compare
I add a new page not found because maybe the url is not valid I create dynamic url base on list id and check if it exists in list data then pass to url, otherwise return page not found I modified the list name of the personal list to a link in preparation to view the listing details References: RM-1003
I updated the UI for the add list button to be better. In the list summary I take the list name and count all the tasks to show and update UI References: RM-1003
I create a list task component to display a task from list tasks. I modified the css for better UI list task I create new list as priorities and modify priority for all tasks in mock data to show the priority of the task References: RM-1003
After finishing the details of a list in the right area but the UI is not good then I need to fix some css in the right area to show the list details better The selected list in the personal list is not selected after the page refresh so i check if being show lists details then set checked References: RM-1003
vxduc9999
force-pushed
the
1003-view-details-of-a-list
branch
from
2f4be57
to
b703b2b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each list should be on a separate dynamic URL based on its id.
We view the details of a list in the right area, including list name,
the number of its tasks, all tasks belonging to this list.