Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

action: support task_limit #85

Closed
mpareja opened this issue Sep 22, 2023 · 5 comments
Closed

action: support task_limit #85

mpareja opened this issue Sep 22, 2023 · 5 comments

Comments

@mpareja
Copy link

mpareja commented Sep 22, 2023

Is there any reason for not supporting the task_limit parameter on the action operator? The underlying implementation map allows it, so it would simply be a matter of forwarding the parameter.
@vxgmichel vxgmichel mentioned this issue Sep 25, 2023
Merged
@vxgmichel
Copy link
Owner

Hi @mpareja and thanks for the report

Is there any reason ...

Good catch, let's fix this: PR #86

vxgmichel added a commit that referenced this issue Sep 26, 2023
@vxgmichel
Add task_limit argument to action operator (issue #85, PR #86)
06c86e2
@vxgmichel
Copy link
Owner

Merged, thanks!

@mpareja
Copy link
Author

mpareja commented Sep 28, 2023

Okay, this is great - I'm already using it successfully, thanks!

One thing to note in 0.5.0: I'm using the new @pipable_operator but I was forced to import from:

from aiostream.core import pipable_operator

@vxgmichel
Copy link
Owner

Ooops how did I miss that, fixed in 0.5.1

Sorry for the inconvenience :)

@mpareja
Copy link
Author

mpareja commented Sep 28, 2023

No worries @vxgmichel, I'm super happy to have your nice tight library, it's come in very useful!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mpareja @vxgmichel