Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make operators a singleton object instead of a class #106

Merged
merged 3 commits into from
May 7, 2024

Conversation

vxgmichel
Copy link
Owner

This has the benefit of not exposing the operator methods (raw and pipe) to the produced stream.

It was also confusing for operators to be a class as they're written in lowercase.

Also, the implementation of the operator and pipe_operator decorators are updated to be more readable.

Copy link

codecov bot commented May 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (4952900) to head (102b780).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #106   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           15        15           
  Lines         1058      1088   +30     
=========================================
+ Hits          1058      1088   +30     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vxgmichel vxgmichel force-pushed the operator-as-object-attempt branch 2 times, most recently from afe3f12 to dc0c41c Compare May 7, 2024 16:13
@vxgmichel vxgmichel force-pushed the operator-as-object-attempt branch from dc0c41c to 102b780 Compare May 7, 2024 16:16
@vxgmichel vxgmichel merged commit c30c749 into main May 7, 2024
42 checks passed
@vxgmichel vxgmichel deleted the operator-as-object-attempt branch May 7, 2024 16:21
vxgmichel added a commit that referenced this pull request May 7, 2024
vxgmichel added a commit that referenced this pull request May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant