chore: leave todo, come back and resolve immutable offsets at compile…

… time
vyperlang · Nov 12, 2021 · 417e6aa · 417e6aa
1 parent 90c8594
commit 417e6aa
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 0 deletions.
diff --git a/vyper/old_codegen/expr.py b/vyper/old_codegen/expr.py
@@ -340,6 +340,7 @@ def parse_Name(self):
             else:
                 immutable_section_size = self.context.global_ctx.immutable_section_size
                 offset = self.expr._metadata["type"].position.offset
+                # TODO: resolve code offsets for immutables at compile time
                 return LLLnode.from_list(
                     ["sub", "codesize", immutable_section_size - offset],
                     typ=var.typ,

diff --git a/vyper/old_codegen/parser.py b/vyper/old_codegen/parser.py
@@ -180,6 +180,7 @@ def parse_regular_functions(
 
     immutables = [_global for _global in global_ctx._globals.values() if _global.is_immutable]
 
+    # TODO: enable usage of the data section beyond just user defined immutables
     if len(immutables) > 0:
         # find position of the last immutable so we do not overwrite it in memory
         # when we codecopy the runtime code to memory