Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VIP: len return type should be uint256 #1979

Closed
iamdefinitelyahuman opened this issue May 18, 2020 · 0 comments · Fixed by #2032
Closed

VIP: len return type should be uint256 #1979

iamdefinitelyahuman opened this issue May 18, 2020 · 0 comments · Fixed by #2032
Labels
VIP: Approved VIP Approved
Milestone
v0.2.0 Release

Comments

@iamdefinitelyahuman
Copy link
Contributor

Simple Summary

The builtin len function should return uint256.

Motivation

It is impossible to have a negative length. As such, uint256 is the type I would expect to receive from this function.

Specification

len(b: bytes) → uint256

Backwards Compatibility

It's a small but breaking change.

Copyright

Copyright and related rights waived via CC0
@fubuloubu fubuloubu added the VIP: Discussion Used to denote VIPs and more complex issues that are waiting discussion in a meeting label May 18, 2020
@fubuloubu fubuloubu mentioned this issue May 18, 2020
Closed
5 tasks
@iamdefinitelyahuman iamdefinitelyahuman mentioned this issue May 19, 2020
Closed
@iamdefinitelyahuman iamdefinitelyahuman added VIP: Approved VIP Approved and removed VIP: Discussion Used to denote VIPs and more complex issues that are waiting discussion in a meeting labels May 26, 2020
@fubuloubu fubuloubu added this to the v0.2 Release milestone Jun 21, 2020
@iamdefinitelyahuman iamdefinitelyahuman mentioned this issue Jun 25, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
VIP: Approved VIP Approved
Projects
None yet
Milestone
v0.2.0 Release
Development

Successfully merging a pull request may close this issue.

Adjust return type of len iamdefinitelyahuman/vyper
2 participants
@fubuloubu @iamdefinitelyahuman