You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It actually is a breaking change, because it changes the Method ID of the getter function. I think this is a good thing though, as it will match the Solidity implementation.
Ahh, I forgot about interfaces we generate from other contracts. Was thinking it wasn't breaking since it would only affect newly compiled contracts. Good call.
Simple Summary
When an array is declared public, the generated getter should accept
uint256
instead ofint128
in order to handle the lookups.Motivation
We do not allow array lookups with negative numbers, so the use of
int128
is unintuitive.Specification
As an example, the following variable:
Should produce a getter with the following signature:
Backwards Compatibility
This is not a breaking change, but it does amount to a deviation in expected behavior.
Dependencies
Not dependent, but related to #1979
Copyright
Copyright and related rights waived via CC0
The text was updated successfully, but these errors were encountered: