Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

codesize regression with large calldata arrays which need to be clamped #2656

Open
charles-cooper opened this issue Feb 13, 2022 · 1 comment
Open

codesize regression with large calldata arrays which need to be clamped #2656

charles-cooper opened this issue Feb 13, 2022 · 1 comment
Assignees
@charles-cooper

Comments

@charles-cooper
Copy link
Member

Version Information

  • vyper Version (output of vyper --version): as of v0.3.0

What's your issue about?

Clampers should run in a loop, but instead they are unrolled

How can it be fixed?

make_setter should use a loop in general when the number of elements is large enough
@charles-cooper charles-cooper self-assigned this Feb 13, 2022
@charles-cooper charles-cooper mentioned this issue Mar 14, 2022
Closed
7 tasks
@charles-cooper
Copy link
Member Author

guessing we also want to loop for ABI encoding large arrays

@charles-cooper charles-cooper mentioned this issue Mar 31, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@charles-cooper charles-cooper

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

tune code size / gas for bytes copy routines charles-cooper/vyper
1 participant
@charles-cooper