-
-
Notifications
You must be signed in to change notification settings - Fork 810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tune code size / gas for bytes copy routines #2738
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2738 +/- ##
===========================================
- Coverage 86.66% 68.37% -18.30%
===========================================
Files 93 93
Lines 9886 9910 +24
Branches 2420 2423 +3
===========================================
- Hits 8568 6776 -1792
- Misses 831 2458 +1627
- Partials 487 676 +189
Continue to review full report at Codecov.
|
merge shared code blocks in dynarray and static array/tuple
charles-cooper
force-pushed
the
fix_codesize
branch
from
April 2, 2022 17:31
44b548e
to
f27bb86
Compare
they are only referenced once, in a single load/store, so it is not necessary to cache them
superseded by #3483 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
fix #2656, also unroll copy_bytes when the number of words is small (<8).
should refactor a little because a couple code paths look suspiciously similar. also consider exposing the constants
UNROLL_WORD_COPY_TUNING
andROLL_ARRAY_TUNING
as optimizer options.How I did it
How to verify it
check IR following contract -- foo has loops, bar has unrolled, baz has loops
Commit message
Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)
Description for the changelog
Cute Animal Picture