-
-
Notifications
You must be signed in to change notification settings - Fork 788
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: improve batch copy performance #3483
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
per cancun, eip-5656
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #3483 +/- ##
==========================================
+ Coverage 89.17% 89.19% +0.01%
==========================================
Files 84 84
Lines 10882 10948 +66
Branches 2488 2503 +15
==========================================
+ Hits 9704 9765 +61
- Misses 767 771 +4
- Partials 411 412 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
this commit adds the `--optimize` flag to the vyper cli, and as an option in vyper json. it is to be used separately from the `--no-optimize` flag. this commit does not actually add different options, just adds the flag and threads it through the codebase so it is available once we want to start differentiating between the two modes, and sets up the test harness to test both modes.
note: mypy needed bump to 0.940 to handle match/case
it was probably important when we supported pre-constantinople targets, not anymore
it passes in no-opt mode now as well
across optimization modes
fubuloubu
approved these changes
Jul 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
per cancun, eip-5656. also add heuristics to use loops vs unrolled loops for batch copies.
bytecode size comes down roughly 2-5%, i checked curve-stablecoin/Stableswap.vy, tricrypto-ng/TriCryptoOptimizedWETH.vy and vaults/VaultV3.vy. there are potentially more places where we could use
copy_bytes
tooWhat I did
How I did it
How to verify it
Commit message
Description for the changelog
Cute Animal Picture