Fix tuple return #1175
Merged
Fix tuple return #1175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charles-cooper
force-pushed
the
fix-tuple-return
branch
from
f76897e to
e5286ac
Compare
|
Will review once #1115 is merged. |
The calls to make_setter did not have the destination type set correctly. Fixes vyperlang#1006
charles-cooper
force-pushed
the
fix-tuple-return
branch
from
e5286ac to
3b69933
Compare
|
@jacqueswww rebased this branch so the merge is clean |
jacqueswww
approved these changes
Jan 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Fix #1006
- How I did it
Set the destination type correctly for
make_setterto typecheck in the tuple return code- How to verify it
See test
- Description for the changelog
Fix typecheck for tuple return
- Cute Animal Picture