Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow boolean as default parameter #1466

Merged
merged 1 commit into from
Jun 25, 2019
Merged

Allow boolean as default parameter #1466

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion vyper/signatures/function_signature.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,8 @@ def from_definition(cls,

# Validate default values.
for default_value in getattr(code.args, 'defaults', []):
if not isinstance(default_value, (ast.Num, ast.Str, ast.Bytes, ast.List)):
allowed_types = (ast.Num, ast.Str, ast.Bytes, ast.List, ast.NameConstant)
jacqueswww marked this conversation as resolved.
Show resolved Hide resolved
if not isinstance(default_value, allowed_types):
raise FunctionDeclarationException("Default parameter values have to be literals.")

# Determine the arguments, expects something of the form def foo(arg1:
Expand Down