Fix private underflow #1470
Merged
Fix private underflow #1470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Appropriate 'cute' image, figuring this out was a challenge indeed! 👅 |
jacqueswww
approved these changes
Jun 5, 2019
|
Great stuff! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Fix #1463
How I did it
The dynamic section copier skipped null elements in case there was a difference between len(array) and maxlen(array) since elements past-the-end of memory are null. However, that could fail if the array length was nonzero but it had null elements. This fixes the dynamic section copier by explicitly using the length specified in the ABI encoding for byte arrays.
How to verify it
Description for the changelog
Cute Animal Picture