Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use pathlib instead of os.path #1566

Merged
merged 1 commit into from
Aug 8, 2019

Conversation

iamdefinitelyahuman
Copy link
Contributor

What I did

Replace os.path with pathlib.Path - it makes for much cleaner code and reduces headaches when dealing with Windows file systems.

How to verify it

Run the tests.

Cute Animal Picture

image

@iamdefinitelyahuman
Copy link
Contributor Author

Did this as a lead-up to #1367 - implementing relative imports will mean a lot more interaction with the file system.

@fubuloubu fubuloubu requested a review from davesque August 8, 2019 14:37
Copy link
Contributor

@davesque davesque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks much cleaner. Reviewing these changes reminds me of our need for script invocation tests! :)

@davesque davesque merged commit 8d5918f into vyperlang:master Aug 8, 2019
@davesque
Copy link
Contributor

davesque commented Aug 8, 2019

@fubuloubu @iamdefinitelyahuman By the way, I did run the vyper bin manually a couple of times to make sure the affected code paths were still behaving as expected, but I think I or someone should revisit the script invocation pr #1337 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants