Remove for orelse for For #1633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fubuloubu
approved these changes
Oct 2, 2019
charles-cooper
approved these changes
Oct 6, 2019
|
@jacqueswww this is ready for merge, right? |
|
Yes, it is.
…On Thu, 24 Oct 2019, 01:21 Bryant Eisenbach ***@***.***> wrote:
@jacqueswww <https://github.com/jacqueswww> this is ready for merge,
right?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1633>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABUY2UHADP2ZCZ6GG72ARFDQQDL7ZANCNFSM4I4UOPEA>
.
|
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
We don't support For .. orelse. We should not let it blindly not generate code.
How I did it
How to verify it
Description for the changelog
Cute Animal Picture