-
-
Notifications
You must be signed in to change notification settings - Fork 788
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Python3.8 #1678
Conversation
ce61beb
to
e78a1ad
Compare
Huh, fuzzing actually caught something this time lol |
Failing test should be fixed by #1679 |
@iamdefinitelyahuman rebase master |
I'd like to merge #1657 first and rebase on that to ensure we're playing with all the latest toys |
7d44c61
to
aab7e5f
Compare
vyper/ast_utils.py
Outdated
else: | ||
class_name = node.__class__.__name__ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure I understand the fix here, as far as I can tell all these types are replaced by Constant(value=) now, doesn't that mean we have to translate each constant type and port over the value attribute (e.g. .s
for Str and .n
for number) ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And would that mean something the replacement step would have to map something like isinstance(node.value, str)
=> vyper_ast.Str(s=node.value)
(if isinstance(node, python_ast.Constant).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See new commits based on our discussion 👍
technically, cc @carver |
24d5e4f
to
cbefaa8
Compare
Spending some time on this today. |
Just released blake2b-py v0.1.3 that includes support for python 3.8. |
cbefaa8
to
23013ac
Compare
What I did
Add support for Python 3.8
How I did it
Constant
python AST type with deprecated type names when generating Vyper AST nodes.How to verify it
Run the tests
Description for the changelog
Cute Animal Picture