Comment at EOF bugfix #1720
Merged
Comment at EOF bugfix #1720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charles-cooper
requested changes
Nov 12, 2019
iamdefinitelyahuman
force-pushed
the
comment-eof-bugfix
branch
from
3ebafff
to
c321b88
Compare
fubuloubu
requested changes
Nov 12, 2019
iamdefinitelyahuman
force-pushed
the
comment-eof-bugfix
branch
from
c321b88
to
98962a7
Compare
fubuloubu
approved these changes
Nov 12, 2019
charles-cooper
added a commit
to charles-cooper/vyper
that referenced
this pull request
Aug 9, 2021
The previous fix in vyperlang#1720 stopped working because the modified source code was only being provided to some compilation steps (compile_codes) but not others (get_interface_codes).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Fix #1701
How I did it
Append
\nto all source code before compiling.How to verify it
Run tests.
Cute Animal Picture