Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix struct assignment order #1728

Merged
merged 3 commits into from
Nov 28, 2019
Merged

Fix struct assignment order #1728

merged 3 commits into from
Nov 28, 2019

Conversation

charles-cooper
Copy link
Member

@charles-cooper charles-cooper commented Nov 14, 2019 •
edited
Loading

What I did

Fix #1686

How I did it

fix the order of the RHS arguments in make_setter

How to verify it

cf. tests

Description for the changelog

Fix order of assignment statements in struct assignment

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@charles-cooper charles-cooper force-pushed the fix_struct_typecheck branch 3 times, most recently from f6c0a39 to 7d67906 Compare November 15, 2019 14:42
@charles-cooper charles-cooper changed the title WIP Fix struct assignment order Fix struct assignment order Nov 15, 2019
fubuloubu
fubuloubu approved these changes Nov 15, 2019
View reviewed changes
tests/parser/globals/test_setters.py Outdated Show resolved Hide resolved
tests/parser/globals/test_setters.py Outdated Show resolved Hide resolved
tests/parser/globals/test_setters.py Show resolved Hide resolved
jacqueswww
jacqueswww suggested changes Nov 22, 2019
View reviewed changes
Copy link
Contributor

@jacqueswww jacqueswww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As part of this I think we should also apply mypy rules for the StructType / TupleLike types in types.py. So we can make sure we always pass a OrderedDict to the self.members :)

vyper/parser/expr.py Show resolved Hide resolved
@charles-cooper charles-cooper mentioned this pull request Nov 27, 2019
Closed
5 tasks
@fubuloubu
Copy link
Member

@jacqueswww 👍 and you can merge this

@charles-cooper
Copy link
Member Author

rebased off latest master to get the new CI to run

@charles-cooper charles-cooper merged commit c677e6f into vyperlang:master Nov 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fubuloubu fubuloubu fubuloubu approved these changes

@jacqueswww jacqueswww jacqueswww approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Struct literals are dependent on key order
3 participants
@charles-cooper @fubuloubu @jacqueswww