Chain ID #1763
Merged
Chain ID #1763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fubuloubu
force-pushed
the
1652-chain-id
branch
from
dd1aac4 to
3428bc9
Compare
|
LGTM. |
jacqueswww
approved these changes
Dec 13, 2019
charles-cooper
requested changes
Dec 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Added the chain ID environment variable per EIP-1344
fixes: #1652
How I did it
Just added another env var
How to verify it
Review tests
Description for the changelog
Added EIP-1344 (Chain ID opcode) support
Cute Animal Picture