Fix #1761: potentially insufficient gas stipend for precompiled

[daejunpark]

What I did

Fix #1761

How I did it

Put all available gas (i.e., ['gas']) for calls to precompiled contracts, especially:

• ECREC (1)
• ID (4)
• ECADD (6)
• ECMUL (7)

Note that calls to SHA256 (2) are already given the full gas.

How to verify it

Check if the changes affect only (and all of) the calls to precompiled.

Description for the changelog

Fix potentially insufficient gas stipend for precompiled contract calls

Cute Animal Picture

[fubuloubu]

LGTM

Applies cleanly to b13: https://github.com/vyperlang/vyper/tree/1761-HOTFIX-v0.1.0-beta.13

NOTE: This branch will not be maintained further.

[fubuloubu]

cc @djrtwo ^

[daejunpark]

@fubuloubu Awesome! Just to make sure, are you going to release the hotfix branch with a version name, like 0.1.0b13.hotfix1761 so that it can be installed using pip (https://github.com/ethereum/eth2.0-specs/blob/dev/deposit_contract/requirements-testing.txt#L2)?

[jacqueswww]

LGTM; yeah sure I think we can do that - you'd just have to pin that version in your requirements.

[fubuloubu]

@daejunpark an alternative is to specify this in your file:

https://github.com/vyperlang/vyper/archive/1761-HOTFIX-v0.1.0-beta.13.tar.gz

I've protected that branch so it doesn't get deleted. I would prefer this to uploading it to pypi.

[djrtwo]

Thank you @fubuloubu. We're an inch away from finishing this formal verification and expect stability from here on out.

Really appreciate the help :)

[fubuloubu]

No problem! Thank you for using Vyper for what is arguably the most important contract in the ecosystem :)

[MrChico]

@daejunpark an alternative is to specify this in your file:

https://github.com/vyperlang/vyper/archive/1761-HOTFIX-v0.1.0-beta.13.tar.gz

I've protected that branch so it doesn't get deleted. I would prefer this to uploading it to pypi.

I think it could be important to make a release as well. For services like etherscan that will need to verify the source code of this contract, it would be valuable to have this version available as a tarball.

Another thing to note is that there was no version bump included in this PR. Something like 0.1.0b13.hotfix1761 could be nice

[fubuloubu]

@MrChico, that's fair

TBH this is the kind of thing I was afraid of happening, but seems unavoidable if we want the deposit contract to be more visible and widely referenced

[djrtwo]

I'm having trouble pip installing from the tar.gz url.

Tried against a number of vyper branches and all failed. Is this an installation that has worked for anyone else?

[charles-cooper]

@djrtwo maybe try this

pip install "git+https://github.com/vyperlang/vyper@1761-HOTFIX-v0.1.0-beta.13"

[fubuloubu]

@djrtwo sorry, I had looked that up but I typically do it the way @charles-cooper laid out