Minmax signing #1790
Merged
Minmax signing #1790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fubuloubu
requested changes
Dec 28, 2019
iamdefinitelyahuman
force-pushed
the
minmax-signing
branch
from
ea00709 to
56c5626
Compare
fubuloubu
approved these changes
Dec 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Fix an error in
minandmaxthat caused incorrect evaluation with signed comparators - closes #1690How I did it
Simplify / adjust logic in
vyper/functions/functions.py- see code, it's fairly straightforward.How to verify it
Run the tests. I added a new test case to check the example given in #1690.
Cute Animal Picture