Edits and checks for modulus, division, and exponentiation #1792
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
How I did it
abs(a) % abs(b)
and then return a negative value ifa < 0
. This is consistent with the results ofSMOD
.ZeroDivisionException
to allow raising zero division errors with code highlightsvyper/parser/expr.py
- mostly raising exceptionsHow to verify it
Run the tests. I added more test cases around these behaviors.
Cute Animal Picture