simplify list return type check #1797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamdefinitelyahuman
force-pushed
the
list-return-type
branch
from
d29da4e
to
6096c45
Compare
fubuloubu
approved these changes
Jan 3, 2020
|
Looks like @jacqueswww added in #533. Waiting on his 👍 |
iamdefinitelyahuman
force-pushed
the
list-return-type
branch
from
6096c45
to
53fd7c6
Compare
charles-cooper
approved these changes
Jan 3, 2020
There was a problem hiding this comment.
i think this is good. waiting on @jacqueswww in case there's any odd edge cases here.
|
This was before we could easily do direct comparisons of the type classes easily; so all good ✔️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Simplify the type check when returning lists - closes #1691
How I did it
Copypasta
How to verify it
Run tests.
Cute Animal Picture