test: various minor edits #1920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamdefinitelyahuman
force-pushed
the
bytes-and-strings-ohmy
branch
from
c3ec22b to
44a9bce
Compare
fubuloubu
approved these changes
Apr 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Various minor test case edits from #1915 that have no bearing on type checking and so can reduce the diff. This is a mix of:
""forb""and vise versa (VIP: Remove type ambiguity in bytes and string literals #1876)valueto_value(VIP: Disallow use of value as a variable name in a function input #1877)int128touint256for certain builtins and kwargs (VIP: Disallow int128 for value and gas kwargs in external function calls #1878)I also added
larktotox.iniisort settings to makeisorthappy.How to verify it
Run tests.
Cute Animal Picture