-
-
Notifications
You must be signed in to change notification settings - Fork 788
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor main compiler logic #1962
Merged
fubuloubu
merged 13 commits into
vyperlang:master
from
iamdefinitelyahuman:refactor-compiler2
May 11, 2020
Merged
Refactor main compiler logic #1962
fubuloubu
merged 13 commits into
vyperlang:master
from
iamdefinitelyahuman:refactor-compiler2
May 11, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1962 +/- ##
==========================================
+ Coverage 86.05% 86.13% +0.07%
==========================================
Files 56 58 +2
Lines 6628 6641 +13
Branches 1685 1684 -1
==========================================
+ Hits 5704 5720 +16
+ Misses 585 584 -1
+ Partials 339 337 -2
Continue to review full report at Codecov.
|
fubuloubu
reviewed
May 11, 2020
144b9c8
to
da12604
Compare
da12604
to
bed6a7b
Compare
fubuloubu
approved these changes
May 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
vyper/compiler.py
into a subpackageHow I did it
Everything is well-documented in the docstrings and module
README.md
- see the diff for more details on how it all works.How to verify it
Run tests.
Cute Animal Picture