-
-
Notifications
You must be signed in to change notification settings - Fork 788
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix raw call outsize #1977
Fix raw call outsize #1977
Conversation
bcbf4a2
to
6037bca
Compare
Codecov Report
@@ Coverage Diff @@
## master #1977 +/- ##
==========================================
+ Coverage 86.58% 87.17% +0.58%
==========================================
Files 58 58
Lines 6636 6637 +1
Branches 1677 1677
==========================================
+ Hits 5746 5786 +40
+ Misses 569 536 -33
+ Partials 321 315 -6
Continue to review full report at Codecov.
|
@charles-cooper could you take a look at the proposed change and let us know if there's something we're missing about how |
I don't really get the purpose of the proposed change. |
Ok I think I understand it now. It's important for variable length return data. I think it is a good change, but using the name |
I like |
Can't figure out how to approve from mobile. But, approved on my end. |
What I did
Do not return empty calldata in
raw_call
. Fixes #1976How I did it
Compare
RETURNDATASIZE
tooutsize
and copy the smaller number of bytes to memory.How to verify it
Run tests. I added / updated some cases. I also had to adjust some failing ones in
test_wallet
where the spirit of the test was that the call should succeed, but there was a check that it returned a non-empty value. Because of this change the value is now empty.Cute Animal Picture