-
-
Notifications
You must be signed in to change notification settings - Fork 788
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Circular call logic and exception annotations #2028
Merged
iamdefinitelyahuman
merged 8 commits into
vyperlang:next
from
iamdefinitelyahuman:feat-ordering
Jun 24, 2020
Merged
Circular call logic and exception annotations #2028
iamdefinitelyahuman
merged 8 commits into
vyperlang:next
from
iamdefinitelyahuman:feat-ordering
Jun 24, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fubuloubu
reviewed
Jun 24, 2020
This solves #1707 right? |
Yes :))) |
Codecov Report
@@ Coverage Diff @@
## next #2028 +/- ##
==========================================
- Coverage 85.09% 85.08% -0.01%
==========================================
Files 83 83
Lines 7982 8051 +69
Branches 1925 1951 +26
==========================================
+ Hits 6792 6850 +58
- Misses 716 721 +5
- Partials 474 480 +6
Continue to review full report at Codecov.
|
b295884
to
d3f8596
Compare
fubuloubu
reviewed
Jun 24, 2020
fubuloubu
approved these changes
Jun 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1707
What I did
Sooooo close....
How to verify it
Run tests. Read code.
Cute Animal Picture