Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract32 kwarg #2036

Merged
merged 3 commits into from
Jun 25, 2020
Merged

Extract32 kwarg #2036

merged 3 commits into from
Jun 25, 2020

Conversation

iamdefinitelyahuman
Copy link
Contributor

What I did

Change keyword in extract32 from type to output_type to be consistent with #2035

How to verify it

Run tests.

Cute Animal Picture

image

fubuloubu
fubuloubu approved these changes Jun 25, 2020
View reviewed changes
Copy link
Member

@fubuloubu fubuloubu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks alright, although I question why we have this function in the first place. slice + convert would do the same thing (also, abi_decode should eventually do the same thing too)

@fubuloubu fubuloubu merged commit 7aeeb52 into vyperlang:master Jun 25, 2020
@iamdefinitelyahuman iamdefinitelyahuman deleted the extract32-kwarg branch June 25, 2020 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fubuloubu fubuloubu fubuloubu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iamdefinitelyahuman @fubuloubu