Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

assert/raise modifications #2050

Merged
merged 5 commits into from
Jun 26, 2020
Merged

assert/raise modifications #2050

merged 5 commits into from
Jun 26, 2020

Conversation

iamdefinitelyahuman
Copy link
Contributor

What I did

  • remove constancy checks on assert statements
  • remove the assert_modifiable builtin function
  • allow raise without a reason, with a reason >32 chars long, or with UNREACHABLE

The documentation isn't perfect, but I plan to add a new section for statements where I'll end up rewriting all of this anyway.

Closes #1902

How to verify it

Run tests.

Cute Animal Picture

image

fubuloubu
fubuloubu approved these changes Jun 26, 2020
View reviewed changes
vyper/parser/context.py Show resolved Hide resolved
vyper/parser/expr.py Show resolved Hide resolved
vyper/parser/external_call.py Show resolved Hide resolved
vyper/parser/stmt.py Show resolved Hide resolved
@iamdefinitelyahuman iamdefinitelyahuman merged commit 74d38ce into vyperlang:master Jun 26, 2020
@iamdefinitelyahuman iamdefinitelyahuman deleted the assert-modifiable branch June 26, 2020 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fubuloubu fubuloubu fubuloubu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

VIP: Allow raise without reason string
2 participants
@iamdefinitelyahuman @fubuloubu