Bounds checks for exponentiation #2072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored by: Bryant Eisenbach <fubuloubu@gmail.com>
fubuloubu
requested changes
Jun 30, 2020
fubuloubu
reviewed
Jun 30, 2020
fubuloubu
reviewed
Jun 30, 2020
|
This pull request introduces 1 alert when merging e0c596a into bd8e0d3 - view on LGTM.com new alerts:
|
iamdefinitelyahuman
force-pushed
the
safe-exp
branch
from
e0c596a to
e58eafc
Compare
fubuloubu
approved these changes
Jun 30, 2020
Co-authored-by: Bryant Eisenbach <3859395+fubuloubu@users.noreply.github.com>
iamdefinitelyahuman
force-pushed
the
safe-exp
branch
from
e58eafc to
f569d41
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Add overflow checks for exponentiation
Closes #1684
Closes #1685
How I did it
Given
a ** b:aorbis a literal, calculate the highest possible variable value at compile-time, and perform a check against that value at runtime. The logic for finding the upper limits is thanks to @fubuloubu's proof of concept 🙏 I'm just a copy-pasteraandbare variables, raise an exception suggesting the use ofpow_mod256pow_mod256that allows access to theEXPinstruction without any overflow checksHow to verify it
Run tests. I added quite a few new cases.
Cute Animal Picture