Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Properly handle default arguments with a size > 1 word. Fixes #1987
How I did it
In
vyper/parser/function_definitions/parse_external_function.py::parse_external_function
, useget_size_of_type
to determine the size in memory for each default argument.How to verify it
Run the tests. I added some cases based on the example in the issue. I also verified the behavior for internal functions.
Cute Animal Picture