Make bytes and string uppercase #2080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamdefinitelyahuman
force-pushed
the
uppercase-types
branch
from
872e96e
to
25c73a2
Compare
Merged
fubuloubu
approved these changes
Jul 2, 2020
| @@ -91,7 +91,8 @@ def get_type_from_abi( | |||
| type_string = abi_type["type"] | |||
| if type_string == "fixed168x10": | |||
| type_string = "decimal" | |||
| # TODO string and bytes | |||
There was a problem hiding this comment.
in anticipation of this, I guess 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Rename
bytesandstringtoBytesandStringRelated to #1440
How I did it
A lot of grepping.
How to verify it
Run tests.
Description for the changelog
bytesandstringhave been changed toBytesandStringCute Animal Picture