fix: type checking in for loops #2096

iamdefinitelyahuman · 2020-07-05T11:18:39Z

Fix a bug in the type checker preventing proper checks during for loops. This wasn't a critical issue, as any failure is still caught in parser.
Improve how exception messages are handled during a failed type check in a for loop

The main issue was from an improperly indented return. Ooops.
For the exception message, I'm tracking every exception raised during the iterative check. At the end, if they're all the same exception, I raise it instead of the more generic "could not determine type for i".

Run tests.

fubuloubu · 2020-07-05T14:50:38Z

vyper/context/validation/local.py

        for type_ in type_list:
+            # type check the fdor loop body using each possible type for iterator value


iamdefinitelyahuman requested a review from fubuloubu July 5, 2020 11:18

fubuloubu approved these changes Jul 5, 2020

View reviewed changes

fix: type checking for loops

b18438b

iamdefinitelyahuman force-pushed the fix-type-checking-for-loops branch from c7c479e to b18438b Compare July 5, 2020 15:20

iamdefinitelyahuman merged commit 0e6141a into vyperlang:master Jul 5, 2020

iamdefinitelyahuman deleted the fix-type-checking-for-loops branch July 5, 2020 16:37

Provide feedback

		for type_ in type_list:
		# type check the fdor loop body using each possible type for iterator value