-
-
Notifications
You must be signed in to change notification settings - Fork 788
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Array index typecheck #2108
Array index typecheck #2108
Conversation
Add a test |
This pull request introduces 1 alert when merging 431bde4 into d585a4c - view on LGTM.com new alerts:
|
431bde4
to
f6d8513
Compare
This pull request introduces 1 alert when merging f6d8513 into d585a4c - view on LGTM.com new alerts:
|
After following the doc and executing brownie test, I faced an error: E brownie.exceptions.EventLookupError: Unknown key '_value' - the 'DataChange' event includes these keys: setter, value The error is quite explanatory, the event DataChange has been defined with keys `value` and `setter` and were being accessed in the test cases by `_value` and `_setter`. Thus the proposed change
f6d8513
to
24b7a3d
Compare
Codecov Report
@@ Coverage Diff @@
## master #2108 +/- ##
==========================================
- Coverage 85.02% 84.12% -0.91%
==========================================
Files 83 83
Lines 8261 8276 +15
Branches 1992 1994 +2
==========================================
- Hits 7024 6962 -62
- Misses 740 816 +76
- Partials 497 498 +1
Continue to review full report at Codecov.
|
This pull request introduces 1 alert when merging 24b7a3d into 71568de - view on LGTM.com new alerts:
|
What I did
__repr__
to abstract types to improve readability of error messages.How I did it
When an index value is not a literal integer, call to
validate_expected_type
and expectIntegerAbstractType
How to verify it
Run tests.
Cute Animal Picture