Raise on not-types when type checking #2118
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
When type checking, raise immediately if a non-type value is encountered (e.g. a type primitive or uncalled builtin function)
How I did it
in
vyper/context/validation/utils.py
, add a kwargonly_definitions
to_ExprTypeChecker.get_exact_type_from_node
and_ExprTypeChecker.get_possible_types_from_node
. ifTrue
and any values aren't definitions, raiseInvalidReference
.How to verify it
Run the tests.
Cute Animal Picture