Improved for loop TypeMismatch exception #2119
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Improve exception on a failed for loop type check.
How I did it
When the target value in a for loop has multiple potential types, and using each type creates a different
TypeMismatch
, display all of the exceptions with an explanation as to what happened.To do so, I've modified the
nodes
member ofVyperException
to be calledannotations
- it can now also be given as a tuple of("message", node)
. This lets us attach specific messages to each annotation. I think there will be other places this is useful in the future.How to verify it
Run tests.
Cute Animal Picture