Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve exception on incorrect interface #2131

Merged
merged 1 commit into from
Aug 19, 2020
Merged

Improve exception on incorrect interface #2131

merged 1 commit into from
Aug 19, 2020

Conversation

iamdefinitelyahuman
Copy link
Contributor

What I did

Improve the error message when using a 0.1.x style interface.

How I did it

  • If an interface contains constant or modifying, inform the user to change it to view/pure or payable/nonpayable.
  • If an interface is completely wrong, ensure the annotation points at the body

How to verify it

Make sure tests are passing.

Cute Animal Picture

image

@fubuloubu fubuloubu merged commit 0879886 into vyperlang:master Aug 19, 2020
@iamdefinitelyahuman iamdefinitelyahuman deleted the fix-interface-exceptions branch August 19, 2020 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fubuloubu fubuloubu fubuloubu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iamdefinitelyahuman @fubuloubu