Fix: constant folding on lhs of assignments #2137
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Fix a folding issue where constants used in binaries operations inside a subscript were not being correctly folded.
For example, the following currently fails to compile because
FOO+1
is not folded:How I did it
The existing logic does not fold constants on the left-hand side of an assignment, unless the constant's parent is a
Subscript
. To fix this, I'm now checking that the constant has an ancestor who is aSubscript
.How to verify it
Run tests. I expanded the test cases around this functionality to check this specific occurrence.
Cute Animal Picture