Fix: invalid AnnAssign exception #2176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2176 +/- ##
==========================================
- Coverage 85.27% 84.41% -0.87%
==========================================
Files 83 83
Lines 8400 8403 +3
Branches 2031 2032 +1
==========================================
- Hits 7163 7093 -70
- Misses 733 807 +74
+ Partials 504 503 -1
Continue to review full report at Codecov.
|
fubuloubu
approved these changes
Sep 30, 2020
| @@ -170,6 +170,10 @@ def __init__( | |||
| ) | |||
|
|
|||
| def visit_AnnAssign(self, node): | |||
| name = node.get("target.id") | |||
| if name is None: | |||
| raise VariableDeclarationException("Invalid assignment", node) | |||
iamdefinitelyahuman
force-pushed
the
fix-annassign
branch
from
2479ef2
to
0d6815b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Correctly handle an invalid AnnAssign during function-scoped type checking.
Fixes #2157
Cute Animal Picture