Better exception on invalid subscript #2177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2177 +/- ##
==========================================
+ Coverage 85.32% 85.34% +0.02%
==========================================
Files 83 83
Lines 8403 8408 +5
Branches 2032 2033 +1
==========================================
+ Hits 7170 7176 +6
+ Misses 731 730 -1
Partials 502 502
Continue to review full report at Codecov.
|
iamdefinitelyahuman
force-pushed
the
fix-subscript-error
branch
from
e4d5a4b
to
6ef2d7f
Compare
fubuloubu
approved these changes
Oct 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Improve the exception raised on an invalid subscript.
How I did it
Prior to the general "Subscript must be a literal integer", first check that the subscript is a valid something. If it isn't, the exception raised can be more useful in determining what went wrong. For example, a typo in a constant variable name.
Cute Animal Picture