Calculate array index offsets at compile time #2187
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
When accessing an array in memory, calculate the offset during compile-time instead of runtime.
How I did it
In
parser_utils
, I added a private method_make_array_index_setter
that generates different LLL if the target value is in memory and the offset is fixed. I also avoid the use ofwith
where possible, so no values are needlessly placed on the stack.How to verify it
Run the tests. I didn't add any new cases, but this behavior is well tested within the existing suite.
Cute Animal Picture